Custom endpoint_url and 'ShardId'#28
Open
nicholasball wants to merge 2 commits intoNerdWalletOSS:masterfrom
Open
Custom endpoint_url and 'ShardId'#28nicholasball wants to merge 2 commits intoNerdWalletOSS:masterfrom
nicholasball wants to merge 2 commits intoNerdWalletOSS:masterfrom
Conversation
nicholasball
commented
Nov 16, 2020
nicholasball
commented
- Add custom endpoint_url to consumer/producer and state
- Return 'ShardId' in item
sethsaperstein
approved these changes
Nov 27, 2020
|
Is there anything I can do to move this forward? I really need this PR merged :) |
borgstrom
suggested changes
Feb 1, 2021
Contributor
borgstrom
left a comment
borgstrom
left a comment
There was a problem hiding this comment.
Hi @nicholasball,
I'm 👍 on the end point change, but would like to change the semantics of how the shard_id is returned to keep the data envelope stable for existing use cases.
We also will need a test that covers return_shard_id.
Comment on lines
+204
to
206
| item['ShardId']=shard_id | ||
| log.debug(item) | ||
| yield item |
Contributor
There was a problem hiding this comment.
I do not like the idea mutating the item.
Instead of adding the ShardId to the item what do you think about adding another option to init (something like return_shard_id=False) that if true would change the yield to:
if self.return_shard_id:
yield shard_id, item
else:
yield item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.